Added RTL to forms front when using ?forceLanguage=he#3107
Added RTL to forms front when using ?forceLanguage=he#3107andreydruz wants to merge 1 commit intonextcloud:mainfrom
?forceLanguage=he#3107Conversation
There was a problem hiding this comment.
Please remove these changes and add them on Transifex. Translations must never be changed directly in the code :)
There was a problem hiding this comment.
Please remove these changes and add them on Transifex. Translations must never be changed directly in the code :)
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Lint problems in unchanged files, so you can fix it by yourself. About Transifex - not familiar with it. Please send manual how to add translation strings. |
|
@andreydruz the lint errors come clearly from your commit :) Regarding the translations: just remove the changes from your commit. They need to be done on Transifex, which is a separate application/portal. I don't know if for your language there are already some translators active. Perhaps @rakekniven can have a look |
Added new Hebrew translations for form interactions and error messages
Hello, Deleted translation files. |
| /** | ||
| * Check if current language is RTL (Right-to-Left) | ||
| * | ||
| * @return bool | ||
| */ | ||
| private function isRTL(): bool { | ||
| $rtlLanguages = ['ar', 'he', 'fa', 'ur', 'ps', 'ku', 'sd', 'yi']; | ||
| $currentLanguage = $this->l10n->getLanguageCode(); | ||
| return in_array($currentLanguage, $rtlLanguages, true); | ||
| } | ||
|
|
There was a problem hiding this comment.
we already have utils for this in server
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
IMHO this is much easier if we just set the language in the template, because our components already support RTL natively.
I fear the "public-rtl.css" will easily gets outdated.
|
I understand, I will use my fork with RTL. |
3 participants
Added new Hebrew translations for form interactions and error messages